Skip to content

Add section about tagging scenarios to acceptance-tests.adoc#624

Merged
phil-davis merged 4 commits into
masterfrom
tagging-scenarios
Feb 20, 2019
Merged

Add section about tagging scenarios to acceptance-tests.adoc#624
phil-davis merged 4 commits into
masterfrom
tagging-scenarios

Conversation

@phil-davis

@phil-davis phil-davis commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

so that developers can know what are the tags used in acceptance test features and scenarios.

Part of issue #156

Comment thread modules/developer_manual/pages/core/acceptance-tests.adoc Outdated
@phil-davis phil-davis dismissed individual-it’s stale review February 20, 2019 06:43

Review comment addressed

@settermjd settermjd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this, @phil-davis. I've had a read through and will make a few, small, changes to help out.

settermjd and others added 2 commits February 20, 2019 10:55
This change helps make better use of native AsciiDoc features, such as
tables, reflows sentences one per-line, uses headers to provide extra
clarity, removes extra formatting in some code blocks.
@settermjd

Copy link
Copy Markdown
Contributor

@phil-davis, I added a series of changes in 69386e9, I hope you don't mind. Just seeking to add extra clarity to your excellent changes.

@phil-davis

Copy link
Copy Markdown
Contributor Author

LGTM to me thanks.
@settermjd @individual-it somebody approve please and we can merge.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backports:
10.1 #629
10.0 #628

@phil-davis phil-davis mentioned this pull request Feb 20, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants